test(e2e): M1 requirements hardening tier#214
Merged
Conversation
vreshch
force-pushed
the
feature/m1b-vault-commands
branch
from
ad5dfa3 to
099f25b
Compare
vreshch
force-pushed
the
feature/m1-e2e-hardening
branch
from
c820f66 to
1a23022
Compare
Adds e2e/m1-requirements.test.ts (@p0) covering every M1 acceptance criterion against the built CLI + a temp config dir: - add --git valid entry (interval + $schema); --git requires a remote - duplicate name + allowlist-failing name rejected - empty vaults.json still carries the $schema link - remove keeps markdown on disk, drops the index db - vaults.yaml accepted; JSON wins when both exist - malformed/unknown-type config fails loudly - update --check reports a verdict, exits 0, never installs 11 e2e green locally (9 new + 2 existing), 3.1s.
vreshch
force-pushed
the
feature/m1-e2e-hardening
branch
from
1a23022 to
58b2ae1
Compare
Contributor
|
🎉 PR Validation ✅ PASSED Commit: Checks:
Ready to merge! ✨ 🔗 View workflow run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E2E hardening for M1 - covers every M1 acceptance criterion with end-to-end tests. Stacked on #213 (base =
feature/m1b-vault-commands); lands after #212 -> #213.Adds
e2e/m1-requirements.test.ts(@p0), driving the builtdist/cli.jsagainst a per-test temp config dir. All offline exceptupdate --check(which the verb tolerates on any network state).Coverage (9 tests)
vault add --gitwrites a valid entry (interval +$schema)--gitrequires a remote valuevaults.jsonstill carries the$schemalinkremovekeeps markdown on disk, drops the index dbvaults.yamlaccepted; JSON wins when both existupdate --checkreports a verdict, exits 0, never installsVerify
npx playwright test m1-requirements vault-offline-> 11 passed locally (9 new + 2 from feat(vault): offline vault list/add/remove + update verb (M1b) #213), 3.1s.type-check:e2e+format:checkgreen.Stack merge order: #212 -> #213 -> this. CI runs once the stack rebases onto master.